After some recent discussion on the topic of mutex poisoning and notably a blog post that I thought was interesting, thoughtful, exhaustive, yet completely disagreed with, I wanted to comment on the debate myself. To me, poisoning-by-default is one of biggest mistakes that were made in the language, next to some others that are a story for a different time.
I was talking about what a codebase would want a non-Result-returning
lock()to look like (the panic message, or forcing abort, extra logging, signal handling…etc).Poisoning (as a negative) is only relevant if we are pretending it matters for performance. And you already conceded that this is not a part of the conversation as far as you’re concerned.
The “rarely relevant” (as in playing any operative role at all) is also pure conjecture, or if we want to be nicer, it’s totally contextual and use-case dependant.
lock_apiprovides a generic interface so you can e.g. seamlessly swipe out primitives fromparking_lotwith primitives fromspin, you know, the whole point behind generic programming!This is in no way comparable with
leftpad. And I wasn’t actually pointing to it as a solution (to the largely non-existing problem). I just wanted to point out that extension traits for synchronisation primitives already exist with wide usage in the ecosystem, since you seemed to not be aware.If you have an aversion to extension traits. Here is a trivial unit struct wrapper solution. You don’t even need to change the
Mutextype name or thelock()method name in your code.use std::ops::{Deref, DerefMut}; use std::sync::Mutex as PMutex; #[repr(transparent)] struct Mutex<T>(PMutex<T>); impl<T> Deref for Mutex<T> { type Target = PMutex<T>; fn deref(&self) -> &Self::Target { &self.0 } } impl<T> DerefMut for Mutex<T> { fn deref_mut(&mut self) -> &mut Self::Target { &mut self.0 } } impl<T> Mutex<T> { fn new(v: T) -> Self { Self(PMutex::new(v)) } fn lock<'a>(&'a self) -> std::sync::MutexGuard<'a, T> { self.0.lock().expect("poisoned") } } fn main() { let m = Mutex::new(false); // oh look, it's a non-Result returning lock() *m.lock() = true; dbg!(*m.lock()); // inner Mutex method API is still available via Deref/DerefMut *m.try_lock().unwrap() = false; dbg!(*m.lock()); }What is the notable relevant problem. Can you state it plainly?
I already told you, convenience, developer experience. Ergonomics basically. None of this is fixed by some code snippet, whether it’s an extension trait or wrapper type. That just makes things worse. This has nothing to do with performance, as I already said.
Can you point the notable relevant inconvenience, bad developer experience, and poor ergonomics developers are suffering from?
Is it all caused by a
lock()method returning aResult?Anything else?