Honestly more readable than a lot of SQL I’ve read. It even has hierarchical grouping.
I was disgusted by the XML at first, but it’s a readable query returning a sane JSON object.
Meanwhile, I’m mantaining Java code where the SQL is a perfectly square wall of text, and some insane mofo decided the way to read the resulting list of Object[] 🤮 is getting each column by index… so I’d switch to SQXMLL in a heartbeat.
React basically figured out how to make XML work.
Remember, XML was actually designed for use cases like this, that’s why it came with XPath and XSLT, which let you make it executable in a sense by performing arbitrary transformations on an XML tree.
Back in the day, at my first coding job, we had an entire program that had a massive data model encoded in XML, and we used a bunch of XSL to programmatically convert that into Java objects, SQL queries, and HTML forms. Actually worked fairly well, except of course that XSL was an awful language to do that all in.
React simply figured out how to use JavaScript as the transformation language instead.
it’s a readable query returning a sane JSON object.
No it’s not. What table is the data supposed to be coming from…?
Check out JOOQ.
JOOQ made me realize that most ORMs suck
true, but having it look like a component might get annoying. since this is likely to stay at the top, having an island of non components between two components might make it hard to see where functions start and end. and if this isn’t used directly inside a component it’ll just look dumb and inefficient (this also looks like it’ll take way more to edit once you change something)
I think I agree with you both. I’m not a Node developer; could you keep your SQL objects/components in a separate file so that they don’t clutter up other logic?
Yes
It is so readable that you missed the fact it doesn’t have the FROM clause
Honestly not the worst thing I’ve seen.
I’d like you to think for a moment about CTEs, the HAVING clause, window functions and every other funky and useful thing you can do in SQL … Now just think, do you think that this syntax supports all those correctly?
sql syntax doesn’t support even itself correctly i fail to see your point
Probably no better or worse than any other ORM written in a more traditional language. Worst comes to worst, you can always escape to plain SQL.
deleted by creator
Ah yes. That’s what the kids call “sqlx” right?
NGL, if it has real time code completion and compile time SQL checks, this is fine.
I actually like this. This would allow reuse of all the infrastructure we have around XML. No more SQL injection and dealing with query parameters? Sign me up!
Assuming it’s built well. As someone else pointed out, it doesn’t look quite right here.
So you mean like parameterized queries, which exist?
Better than parameterized queries. Yes, we have stuff like
query("INSERT INTO table(status, name) VALUES ($1, $2);").bind(ent.status).bind(ent.name).execute..., but that’s kind of awful isn’t it? With XML queries, we could use any of the XML libraries we have to create and manipulate XML queries without risking ‘XML injection’. e.g we could convert ordinary structs/classes into column values automatically without having to use any ORM.I mean, that’s just a bad library interface. With a halfway decent interface, you can do something like
query('insert into foo (status, name) values (:status, :name)', ent)No orm required. With tagged templates in JS, you can do
q`insert into foo (status, name) values (${ent.status}, ${ent.name})`Even wrap it in a function with destructuring to get rid of
ent:const addFoo = (q, {status, name}) => q`insert into foo (status, name) values (${status}, ${name})`Typescript can add type safety on top of that, of course. And there’s the option to prepare a query once and execute it multiple times.
Honestly, the idea of manipulating XML queries, if you mean anything more fancy than the equivalent of parameter injection, sounds over-complicated, but I’d love to see a more concrete example of what you mean by that.
I was thinking along the lines of
Plenty of libraries can build the XML using structs/classes. e.g. with serde:
//Data type for row #[derive(serde::Serialize)] pub struct Foo { pub status: String, pub name: String, } //Example row let ent = Foo { status: "paid".into(), name: "bob".into(), } //Example execution sqlx::query(&serde_xml_rs::to_string(&InsertStmt{ table: "foo".into(), value: &ent, })?).execute(&conn)?;Or with jackson-dataformat-xml:
//Data type for row public class Foo { public string status; public string name; } //Example row Foo ent = new Foo(); foo.status = "paid"; foo.value = "bob"; //Example execution XmlMapper xmlMapper = new XmlMapper(); String xml = xmlMapper.writeValueAsString(new InsertStmt("foo", ent)); try (Statement stmt = conn.createStatement()) { stmt.executeUpdate(xml) }I don’t do JS (yet) but maybe JSX could also do similar things with XML queries.
No more matching $1, $2, … (or
?for mysql) with individual columns, I could dump entire structs/objects into a query and it would work.
I want to hate this. I really do. But the problem is… I think I like it.
But how do I know if the WHERE clause is AND or OR?
We can say default is
andand add anOrnode foror. Similar to SoP notation, you only write+.How about an
orboolean attribute.
Fair. The constraint nodes should probably exist under an
AndorOrnode.
This needs a bit of work but it could be interesting
Not only is this really gross, it’s also straight up wrong. It’s missing a from clause, and it makes no sense for a where clause to be nested under the select. The select list selects columns from rows that have already been filtered by the where clause. Same for the limit.
Also just gonna go ahead and assume the JSX parser will happily allow SQL injection attacks…
I like the format, though.
Clearly you’ve not had to write and maintain much XML.
I have not. I just thought it looks less goofy than a nested SQL statement split over multiple lines.
What are the issues with XML?
Booooo
When you are assigned to write database queries at work and your academical background is that online react bootcamp
if you don’t believe that adding more structure to the absolute maniacal catastrophe that is sql is a good thing then i’m going to start to have doubts about your authenticity as a human being
If you think this is more structured than traditional SQL, I really disagree. Is this a select * query, it’s ambiguous. Also what table is being queried here there’s no from or other table identifier.
Huh? Sql is one of the most powerful, action packed (as in you can move lots of shit with few commands) languages out there.
It’s transferable and ubiquitous.
powerful isn’t the same as well-structured
it was written to be a language that anybody could read or write as well as english, which just like every other time that’s been tried, results in a language that’s exactly as anal about grammar as C or Python except now it’s impossible to remember what that structure is because adding anything to the language to make that easier is forbidden
when you write a language where its designers were so keen for it to remain human readable that they made deleting all rows in a table the default action, i don’t think “well structured” can be used to describe it
Disagree, the difference between “week structured” and needing to know the rules of the verbs is pretty big, to me.
but sql doesn’t need to be structured that’s what abstraction layers and models are for
SQL is literally structured query language
SQL is incredibly structured. It’s also a very good language, and developers need to stop piling on junk on top of it and producing terrible queries. Learn the damn language. It’s not that hard
Remember kids, JSX is just function calls. It can’t hurt you.
Oh it can and it did.
The most offensive thing here is the
amount={5}attribute. What is it? It’s not XML.It’s a react component and that would be the proper way to give a numerical value in jsx
JSX has grown beyond react, so without further context it doesn’t have to be react.
It’s JSX. It’s used to embed markup into javascript
It’s to embed Javascript into embedded markup in Javascript
please kindly send all javascript into the sun and explode it
This idea is bad and whoever came up with it should feel bad.
It never ceases to amaze me how far idiots will go to avoid learning the most simple things. SQL isn’t hard, people’s difficulty with it says a lot more about them than it does SQL.
People think in different ways. What might seem logical to you might look alien to another. I know SQL well enough to optimize queries, but I find it a lot easier to think about and write queries as LINQ methods. A lot more cleaner and logical to my brain.
Neither is sending form data to the server without any JS. It’s more robust too. Yet almost no form on the web works without JS.
still more readable than sqlalchemy exceptions
I haven’t been this pissed off since LINQ started allowing syntax switches in random-ass places.
